Re: [PATCH] PCI: dwc: tegra194: Clear event counter masks before programming

From: Hans Zhang

Date: Sat Nov 07 2026 - 18:16:32 EST




On 11/8/26 05:50, Manivannan Sadhasivam wrote:
On 2026-11-02 14:38 +0800, Hans Zhang wrote:
When programming the RAS-DES event counter control register, the code only
cleared the event-selection field before OR-ing in the new group, event,
and enable values. This leaves stale bits in the group-select and enable
fields from prior writes.

Clear all three field masks before programming the register so that stale
bits are not preserved across updates.

No functional change intended beyond ensuring the register is rewritten
without carrying over previous field values.

Signed-off-by: Hans Zhang <18255117159@xxxxxxx>

This patch got superseded by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/dwc&id=fe84c0b370889bbf65f75bb75a1810227c7ce150

- Mani


Hello Mani,

This is an evaluation comment from Bjorn regarding me. I didn't notice that Manikanta Maddireddy had made the changes. Please drop this patch.


https://lore.kernel.org/linux-pci/20261019171244.GA2200874@bhelgaas/


Best regards,
Hans