Re: [PATCH v4 0/3] iio: proximity: sx93xx: keep the IRQ balanced across suspend and resume

From: Jonathan Cameron

Date: Sat Nov 07 2026 - 20:29:20 EST


On Sun, 1 Nov 2026 15:55:01 +0530
Arnav Kapoor <kapoorarnav43@xxxxxxxxx> wrote:

> sx9310, sx9324 and sx9360 disable the interrupt in suspend before
> anything that can fail, and don't enable it again when suspend or resume
> fails. One patch per driver, as the Fixes tags differ.
>
> Changes in v4:
> - Enable the interrupt first in resume, so resume mirrors suspend
> (Jonathan). This also drops the sx9310_wake_up() helper from v3.
> - Drop the IRQ 0 wording from the commit messages (Jonathan)
> - Drop Joshua's Reviewed-by, as resume changed

All 3 of these look fine to me, but given they aren't totally trivial
I'm going to leave them for a while in the hope someone will test at least
one of them! If it looks like that's not happening I may pick them
up in a week or two.

Thanks,

Jonathan

>
> v3: https://lore.kernel.org/all/20261028220444.70121-1-kapoorarnav43@xxxxxxxxx/
> v2: https://lore.kernel.org/all/20261026112342.65917-1-kapoorarnav43@xxxxxxxxx/
> v1:
> https://lore.kernel.org/all/20261026100322.16720-1-kapoorarnav43@xxxxxxxxx/
> https://lore.kernel.org/all/20261026100408.16874-1-kapoorarnav43@xxxxxxxxx/
> https://lore.kernel.org/all/20261026100450.17023-1-kapoorarnav43@xxxxxxxxx/
>
> Compile-tested only (W=1); I don't have the hardware and haven't
> reproduced a failing suspend.
>
> Arnav Kapoor (3):
> iio: proximity: sx9310: keep the IRQ balanced across suspend and
> resume
> iio: proximity: sx9324: keep the IRQ balanced across suspend and
> resume
> iio: proximity: sx9360: keep the IRQ balanced across suspend and
> resume
>
> drivers/iio/proximity/sx9310.c | 32 ++++++++++++++++++--------------
> drivers/iio/proximity/sx9324.c | 28 ++++++++++++++++------------
> drivers/iio/proximity/sx9360.c | 30 +++++++++++++++++-------------
> 3 files changed, 51 insertions(+), 39 deletions(-)
>
>
> base-commit: 2ef6f5c4ee56e90c237c5f7687f09e635f7d30a9