Re: [RFC PATCH 14/14] mfd/macsmc: add ioctl to access smc keys
From: Jonathan Cameron
Date: Sat Nov 07 2026 - 20:36:32 EST
On Wed, 4 Nov 2026 14:53:17 -0500
Atharva Tiwari <atharvatiwarilinuxdev@xxxxxxxxx> wrote:
> > If this isn't matching some legacy interface, then we need more
> > on what these do. Maybe they are suited to some other kernel
> > interface? In particular they might need the various controls
> > on how destructive they are that something like fwctl brings.
> >
> > Generally an arbitrary opaque path to firmware isn't a good idea...
> >
> > Jonathan
>
> Here its required, if we write CPU/GPU Pstates and PPT to
> some keys (MSTS MSPC HE0N), we can reduce the temp by 10C
> And We can fix the dreaded PROCHOT signals on macs, Giving
> Same temps as macOS.
Being able to control them is good, but ideally we'd map
these to appropriate subsystems rather than having a magic
interface for them. There might of course be some gaps
that need plugging, but custom ioctl is rarely the way to go
(except maybe due to legacy userspace we don't want to touch!)
Jonathan
>
> But you and Sasha are right, that exposing all keys is a
> bad idea, so i have restricted writing to some keys only.
>