Re: [PATCH v3] ntfs: open a named $DATA stream by name when making room in a record
From: Namjae Jeon
Date: Sat Nov 07 2026 - 21:15:10 EST
On Sun, Nov 8, 2026 at 4:28 AM Wahid Khan <wahidzk0091@xxxxxxxxx> wrote:
>
> When an attribute has to grow and the mft record is full,
> ntfs_resident_attr_resize() walks the other resident attributes and
> converts them to non-resident ones. For $DATA it always opens the
> unnamed data inode of the base inode, even if the attribute found is a
> named stream:
>
> tvi = ntfs_iget(sb, base_ni->mft_no);
> ntfs_attr_make_non_resident(NTFS_I(tvi), value_len);
>
> value_len is the length of the stream, so it does not match the
> attribute that ntfs_attr_make_non_resident() looks up for the unnamed
> inode, and the WARN_ON() on entry fires:
>
> WARNING: fs/ntfs/attrib.c:2115 at ntfs_attr_make_non_resident
> ntfs_resident_attr_resize
> ntfs_attr_expand_locked
> ntfs_expand_for_write
> ntfs_file_write_iter
> vfs_write
>
> With debug output the values were attr_size 13 (unnamed $DATA) and
> data_size 550 (named stream) for the same mft record.
>
> It does not need a damaged volume. A file with an alternate data stream
> whose record has no room left is enough. The fuzzer found it through a
> single changed byte in a file name of an image from mkntfs, which made
> a write grow a resident attribute in such a record.
>
> Use ntfs_attr_iget() with the name of the attribute for a named $DATA
> stream, as is already done for the other attribute types in this loop,
> and keep ntfs_iget() for the unnamed one.
>
> Fixes: 495e90fa3348 ("ntfs: update attrib operations")
> Cc: stable@xxxxxxxxxxxxxxx # v7.1+
> Signed-off-by: Wahid Khan <wahidzk0091@xxxxxxxxx>
> ---
> v3: open a named $DATA stream with ntfs_attr_iget(), as suggested, instead
> of skipping it (v2). Same change as v1 of this patch.
>
> fs/ntfs/attrib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
> index ce7c1b524180..c92d1b06afc3 100644
> --- a/fs/ntfs/attrib.c
> +++ b/fs/ntfs/attrib.c
> @@ -4933,7 +4933,7 @@ static int ntfs_resident_attr_resize(struct ntfs_inode *attr_ni, const s64 newsi
> if (a->type == AT_DATA && !value_len)
> continue;
>
> - if (a->type == AT_DATA)
> + if (a->type == AT_DATA && !a->name_length)
> tvi = ntfs_iget(sb, base_ni->mft_no);
> else
> tvi = ntfs_attr_iget(VFS_I(base_ni), a->type,
This can still deadlock with a concurrent read of the named stream ?
Thread A: grow unnamed $DATA Thread B: read named $DATA
--------------------------------
-----------------------------
hold unnamed inode i_rwsem hold named inode i_rwsem
hold base mrec_lock hold named stream folio 0
ntfs_attr_iget(..., stream_name, ...)
ntfs_attr_make_non_resident()
wait for named stream folio 0 wait for base mrec_lock
Thanks.