Re: [PATCH v8] LoongArch: kexec_file: Fix a modified_cmdline leak

From: Huacai Chen

Date: Sun Nov 08 2026 - 00:05:44 EST


Applied, thanks.

Huacai

On Thu, Nov 5, 2026 at 9:01 PM Jinjie Ruan <ruanjinjie@xxxxxxxxxx> wrote:
>
> machine_kexec_prepare() copies it to KEXEC_CMDLINE_ADDR
> and overwrites the pointer.
>
> Free the heap buffer after the copy.
>
> Cc: Huacai Chen <chenhuacai@xxxxxxxxxx>
> Cc: WANG Xuerui <kernel@xxxxxxxxxx>
> Cc: Kexin Liu <liukexin@xxxxxxxxxx>
> Cc: Youling Tang <tangyouling@xxxxxxxxxx>
> Cc: Qiang Ma <maqianga@xxxxxxxxxxxxx>
> Cc: Tianyang Zhang <zhangtianyang@xxxxxxxxxxx>
> Cc: George Guo <guodongtai@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: d162feec6b6e ("LoongArch: Add preparatory infrastructure for kexec_file")
> Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
> ---
> v7 -> v8:
> - Split out from the patch set as Mike suggested.
> - Link to v7: https://lore.kernel.org/all/20261026075201.699550-1-ruanjinjie@xxxxxxxxxx/
> ---
> arch/loongarch/kernel/machine_kexec.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/loongarch/kernel/machine_kexec.c b/arch/loongarch/kernel/machine_kexec.c
> index 1883cae93bc3..19ccc91b6f2a 100644
> --- a/arch/loongarch/kernel/machine_kexec.c
> +++ b/arch/loongarch/kernel/machine_kexec.c
> @@ -14,6 +14,7 @@
> #include <linux/mm.h>
> #include <linux/of_fdt.h>
> #include <linux/reboot.h>
> +#include <linux/slab.h>
> #include <linux/sched.h>
> #include <linux/sched/task_stack.h>
>
> @@ -56,6 +57,7 @@ int machine_kexec_prepare(struct kimage *kimage)
> */
> memcpy((void *)KEXEC_CMDLINE_ADDR, (void *)kimage->arch.cmdline_ptr,
> strlen((char *)kimage->arch.cmdline_ptr) + 1);
> + kfree((void *)kimage->arch.cmdline_ptr);
> kimage->arch.cmdline_ptr = (unsigned long)KEXEC_CMDLINE_ADDR;
> } else {
> /* Find the command line */
> --
> 2.34.1
>
>