Re: [PATCH net v3] net: dsa: motorcomm: Prevent rx_bytes/tx_bytes underflow

From: David Yang

Date: Sun Nov 08 2026 - 01:08:35 EST


On Sun, Nov 8, 2026 at 1:26 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > + if (res) {
> > + dev_err(dev, "Failed to %s port %d: %i\n", "read stats for",
> > + port, res);
>
> Please don't break strings like that. The reason we allow lines with
> strings to be longer than 80 is because somebody is likely to grep the
> error message in the code to find out why it is being printed.
>
> grep -r "Failed to read stats for" is not going to match.
>
> Andrew
>
> ---
> pw-bot: cr

Hmm that would be more than a pure code movement...