Re: [PATCH batadv-next v3] batman-adv: tt: batch BH re-enable during TT hash walks
From: Sven Eckelmann
Date: Sun Nov 08 2026 - 02:35:40 EST
On Sunday, 8 November 2026 01:01:11 CET Ömer Mete Kaya wrote:
> Each spin_unlock_bh() re-enables bottom halves and, when softirqs are
> pending, processes them inline before returning. During a 1024-bucket
> TT hash walk under network load, the purge worker can be repeatedly
> interrupted by inline softirq processing at every bucket boundary.
[...]
I already told you that this is not directly for net or net-next. Please don't
send this to netdev@xxxxxxxxxxxxxxx or davem@xxxxxxxxxxxxx. The scripts also
tell you this:
$ ./scripts/get_maintainer.pl ./20261108000137.822325-1-omermetekaya0@xxxxxxxxxxxxx
Marek Lindner <marek.lindner@xxxxxxxxxxx> (maintainer:BATMAN ADVANCED)
Simon Wunderlich <sw@xxxxxxxxxxxxxxxxxx> (maintainer:BATMAN ADVANCED)
Antonio Quartulli <antonio@xxxxxxxxxxxxx> (maintainer:BATMAN ADVANCED)
Sven Eckelmann <sven@xxxxxxxxxxxxx> (maintainer:BATMAN ADVANCED)
Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> (maintainer:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT)
Clark Williams <clrkwllms@xxxxxxxxxx> (maintainer:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT)
Steven Rostedt <rostedt@xxxxxxxxxxx> (maintainer:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT)
b.a.t.m.a.n@xxxxxxxxxxxxxxxxxxx (moderated list:BATMAN ADVANCED)
linux-kernel@xxxxxxxxxxxxxxx (open list)
linux-rt-devel@xxxxxxxxxxxxxxx (open list:Real-time Linux (PREEMPT_RT):Keyword:PREEMPT_RT)
Real-time Linux (PREEMPT_RT) status: Supported:Keyword:PREEMPT_RT
And please don't send two versions of the same patch (series) in less than
24h.
> diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
> index b9407ad..ebeb486 100644
> --- a/net/batman-adv/translation-table.c
> +++ b/net/batman-adv/translation-table.c
> @@ -36,6 +36,7 @@
> #include <linux/overflow.h>
> #include <linux/rculist.h>
> #include <linux/rcupdate.h>
> +#include <linux/sched.h>
> #include <linux/skbuff.h>
> #include <linux/slab.h>
> #include <linux/spinlock.h>
Why do you include linux/sched.h? The correct include would have been
#include <linux/bottom_half.h>
#syz test: https://git.open-mesh.org/batadv.git disable-bh
Regards,
Sven
Attachment:
signature.asc
Description: This is a digitally signed message part.