Re: [PATCH v2 02/12] sched/core: Introduce rq_drop_lock()

[Kayra Cizmeci]

Hi Peter,

On Sat, Nov 07, 2026 at 12:59:15PM +0100, Peter Zijlstra wrote:
> Currently rq_unpin_lock() serves a dual purpose, it pairs with both
> rq_pin_lock() and rq_repin_lock(). That is:
> 
> 	rq_pin_lock()
> 	  rq_unpin_lock()
>           rq_repin_lock()
> 	rq_unpin_lock()
> 
> In prepration of making the temporary drop and the final drop

nit. 'prepration' should be 'preparation' :-).

> distinct, this needs another function. Introduce and use
> rq_drop_lock() for the temporary drop, like:
> 
> 	rq_pin_lock()
> 	  rq_drop_lock()
>           rq_repin_lock()
> 	rq_unpin_lock()
> 

Yeah well sadly I couldn't find anything aside from a nit :-(.

I couldn't even find 1 missed place that we didn't transfered to
rq_drop_lock().

Reviewed-by: Kayra Cizmeci <kayracizmeci@xxxxxxxxx>


Cheers.. Woo..

Kayra