Re: [PATCH 1/2] ALSA: ump: clear stale RPN selector on NRPN change

From: Takashi Iwai

Date: Sun Nov 08 2026 - 05:48:18 EST


On Sun, 08 Nov 2026 07:07:08 +0100,
Alyandra SigmabetJir wrote:
>
>
> Hi HyeongJun,
>
> Thank you for bringing up these related cases in the earlier discussion. I
> also appreciate you taking the time to work on the additional patches.
>
> Thank you for clarifying the situation and sharing the details.I appreciate
> your help and the work you've already put into this.

Could you guys cooperate and organize a single fix series? That'd be
nicer at merge.

Also, about the unit test: I'm not much against kunit, but my gut
feeling is that selftest would be more flexible (and less changes in
the core code itself). If that's feasible, let's go in that way.
Otherwise we can take the kunit change. But maybe it's cleaner to
move the test code into another file.


thanks,

Takashi

>
> Sincerely,
> Alyandra
>
> Pada Sab, 7 Nov 2026 21.29, HyeongJun An <sammiee5311@xxxxxxxxx> menulis:
>
> Hello Takashi,
>
> Thanks for adding me, and thanks Alyandra for the patches. Yes, this is
> one of the cases from that thread.
>
> I have patches for the other cases discussed there. They keep the
> RPN/NRPN selection after a send and clear only the data, drop data when
> nothing is selected, and handle a Null NRPN like a Null RPN. They also
> need the same selector change as this patch.
>
> I can send them on top of Alyandra's patches, or as one series that
> includes the selector change, whichever you prefer.
>
> Best regards,
> HyeongJun An
>