Re: [PATCH] net: mscc: ocelot: Fix mirror reference leak on VCAP aux resource error

[Wentao Liang]

Hi Simon,

Sorry for the very late reply.

You are right that a goto-driven unwind ladder is more robust here: it
keeps the release of resources taken earlier in the function next to
the failure paths, so that a failure added later cannot silently skip
it. I have reworked the patch along those lines, and a v2 follows in a
separate mail. The v2 also records how the issue was found and how it
was tested.

I am going through all the remaining review comments one by one now,
and I will not send patches in bulk again, so that I do not get ahead
of my ability to follow up.

Thanks,
Wentao