Re: [PATCH net] net: bridge: fdb: hold hash_lock when an entry roams

From: Julius Bairaktaris

Date: Sun Nov 08 2026 - 06:50:06 EST


(Resent with the lists on Cc; the first copy went to the To:
address only.)

On Mon, 05 Oct 2026, Sashiko wrote:
> - [High] br_fdb_update() looks up the entry with fdb_find_rcu() and
> checks it without a lock, then takes br->hash_lock...

Agreed, the lock would also have needed a hlist_unhashed() check. The
patch is dropped: Nikolay rejected the lock in br_fdb_update(), and the
fix moved to DSA. DSA looks the entry up when it handles each event and
so treats a deleted entry as gone:

https://lore.kernel.org/netdev/cover.1794134495.git.julius@xxxxxxxxxxxxxx/

That series also handles the peer-site finding: a "bridge fdb replace"
that moves an entry onto a DSA user port notifies no deletion, and DSA
now releases the host address when it sees the addition there. The
MAB locked-port and BR_FDB_LOCAL findings are pre-existing bridge
issues that it does not touch.

Julius