Re: [PATCH] net: cxgb4: do not leak a PTP skb when the Tx queue is busy

[Simon Horman]

On Sat, Nov 07, 2026 at 11:03:21AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 (1) · Medium: 1 · Low: 1 (1)
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [Medium] The patch splits the claim on adap->ptp_tx_skb into a NULL
>   check at the top of cxgb4_eth_xmit() (sge.c:1526) and a store about…

The central issue here is the one above.

It seems to me that either this is a pre-existing problem, in which case
the patch description should be updated, or it is a new problem that needs
to be resolved in the context of this patch-set. And either way I think
that a v2 is required.

> - [Low] The commit message lists "an unsupported FCoE offload" as one of
>   the out_free paths that leaks the PTP reference.
> 
> Pre-existing issues:
> - [High] This problem wasn't introduced by this patch, but the consumer
>   side of adapter->ptp_tx_skb has no synchronization.
> - [Low] This problem wasn't introduced by this patch, but
>   cxgb4_eth_xmit() still sets SKBTX_IN_PROGRESS (sge.c:1528) before the…

...

-- 
pw-bot: changes-requested