Re: [PATCH 1/3] hwmon: (max31760) Fix the local temperature limit registers

[Guenter Roeck]

On Sun, Nov 08, 2026 at 03:59:53AM +0000, Stanislav Aleksandrov wrote:
> temp2_max and temp2_crit use each other's registers, so reading them
> shows the local limits swapped and writing temp2_max changes the
> overtemperature (SHDN) threshold.
> 
> Use the high limit (0x0C) for temp2_max and the overtemperature limit
> (0x08) for temp2_crit.
> 
> Fixes: 38b04ad02d0d ("drivers: hwmon: Add max31760 fan speed controller driver")
> Signed-off-by: Stanislav Aleksandrov <lightofmysoul@xxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/max31760.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/max31760.c b/drivers/hwmon/max31760.c
> index 8d3be064b025..e3d86dc4257e 100644
> --- a/drivers/hwmon/max31760.c
> +++ b/drivers/hwmon/max31760.c
> @@ -27,8 +27,8 @@
>  
>  #define REG_TACH(ch)		(0x52 + (ch) * 2)
>  #define REG_TEMP_INPUT(ch)	(0x56 + (ch) * 2)
> -#define REG_TEMP_MAX(ch)	(0x06 + (ch) * 2)
> -#define REG_TEMP_CRIT(ch)	(0x0A + (ch) * 2)
> +#define REG_TEMP_MAX(ch)	((ch) ? 0x0C : 0x06)
> +#define REG_TEMP_CRIT(ch)	((ch) ? 0x08 : 0x0A)
>  
>  #define TEMP11_FROM_REG(reg)	((reg) / 32 * 125)
>  #define TEMP11_TO_REG(val)	(DIV_ROUND_CLOSEST(clamp_val((val), -128000, \