Re: [PATCH v3 2/5] hwmon: sy7636a: fix negative temperatures
From: Guenter Roeck
Date: Sun Nov 08 2026 - 11:00:01 EST
On Sun, Nov 08, 2026 at 09:35:59AM +0000, Pablo Mazzini wrote:
> The thermistor readout is a signed 8-bit value in degrees Celsius.
>
> Fixes: de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
> Signed-off-by: Pablo Mazzini <pmazzini@xxxxxxxxx>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/sy7636a-hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c
> index d51daaf63d63..f01f368d68e5 100644
> --- a/drivers/hwmon/sy7636a-hwmon.c
> +++ b/drivers/hwmon/sy7636a-hwmon.c
> @@ -29,7 +29,7 @@ static int sy7636a_read(struct device *dev, enum hwmon_sensor_types type,
> if (ret)
> return ret;
>
> - *temp = reg_val * 1000;
> + *temp = (s8)reg_val * 1000;
>
> return 0;
> }