Re: [PATCH] net: mvpp2: free pending TX timestamp skbs when the port is stopped

From: Simon Horman

Date: Sun Nov 08 2026 - 12:29:08 EST


On Sat, Nov 07, 2026 at 12:00:58PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 (1) · Medium: 0 · Low: 0 (1)
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The new mvpp2_tx_hwtstamp_flush()
> (drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3422-3436) checks,…

I lean towards this being a pre-existing issue that can be handled
separately from this patch. But I do note that taken at face-value
it severely impacts the reliability of the teardown path and the
usefulness of this patch in practice.

> Pre-existing issues:
> - [High] This problem wasn't introduced by this patch, but it is a
> serious race on the same data.
> - [Low] Baseline decision: not a valid finding against this patch.

...