Re: [PATCH] net: ixgbe: drop the SA reference if secpath_set() fails

[Simon Horman]

On Sun, Nov 08, 2026 at 05:25:04PM +0000, Simon Horman wrote:
> On Sat, Nov 07, 2026 at 11:15:45AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential
> > issue(s) to consider.
> > 
> > Critical: 0 · High: 0 (2) · Medium: 1 · Low: 0
> > 
> > If you believe none of the issues are legitimate, please reply to each
> > issue of Medium severity or higher and explain why the AI is wrong.
> > If any of them are legitimate and you plan to respin, please let patchwork
> > know by including "pw-bot: cr" as a separate line at the end of your reply
> > (one such reply per series is enough).
> > 
> > - [Medium] This patch fixes the SA reference leak in only one of the two
> >   copies of this Rx code.
> 
> I lean towards this being a pre-existing issue that can be handled
> separately from this patch. But I do note that taken at face-value
> it severely impacts the reliability of the  teardown path and the
> usefulness of this patch in practice.

Sorry! I responded to the wrong patch.

The correct response to the issue above is that yes, that is true,
but the requested patch has been posted already. It should have been
part of this patch-set. And the author should keep that in mind for
future patches.

> 
> > 
> > Pre-existing issues:
> > - [High] ixgbe_ipsec_del_sa() unlinks the rx_sa from the RCU hash table
> >   with hash_del_rcu(&rsa->hlist) (line 783) and then zeroes the same…
> > - [High] ixgbe_ipsec_find_rx_state() finds rsa->xs only under
> >   rcu_read_lock() and takes its reference with xfrm_state_hold(), which…
> > 
> > --
> 
> ...