Re: [PATCH 3/4] phy: apple: atc: Add initial M3 series support

[Sven Peter]

On 11/8/26 19:21, Sasha Finkelstein wrote:
> On Nov 8, 2026, at 19:17, Sven Peter <sven@xxxxxxxxxx> wrote:
> > >   /**
> > >    * struct apple_atcphy - Apple Type-C PHY device struct
> > >    * @np: Device node pointer
> > > @@ -599,9 +647,10 @@ struct apple_atcphy {
> > >    struct apple_tunable *lane_usb4[2];
> > >    } tunables;
> > >   + const struct atcphy_hw *hw;
> > >    enum atcphy_mode mode;
> > > - bool swap_lanes;
> > >    int dp_link_rate;
> > > + bool swap_lanes;
> > ugh.. somehow dropped this comment from the email i just sent..
> > is there any reason you move swap_lanes around here?
> It saves 3 bytes of alignment padding. Yes, it makes no sense on
> machines of that performance class, but I could not resist. Can drop it
> in v2.

Fine with me either way ;)

Sven