Re: [PATCH v1 2/4] mfd: max8907: Add ADC client support

[Jonathan Cameron]

On Sun,  8 Nov 2026 11:56:32 +0200
Svyatoslav Ryhel <clamor95@xxxxxxxxx> wrote:

> The Maxim MAX8907 has an 8-channel ADC at a fixed location. Add client
> support for it along with its regmap and interrupts.
> 
> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>

> diff --git a/include/linux/mfd/max8907.h b/include/linux/mfd/max8907.h
> index 35b2ede54f856..cf304afc782d6 100644
> --- a/include/linux/mfd/max8907.h
> +++ b/include/linux/mfd/max8907.h
> @@ -153,6 +153,51 @@
>  #define MAX8907_REG_MPL_CNTL		0x1E
>  
>  /* ADC and Touch Screen Controller register map */
> +#define MAX8907_REG_TSC_STA_INT		0x00
> +#define MAX8907_REG_TSC_INT_MASK	0x01
> +#define MAX8907_REG_TSC_CNFG1		0x02
> +#define MAX8907_REG_TSC_CNFG2		0x03

....

> +/* Regulator stride */

I'm not sure what this means. Stride of what?  Seems to
be some offsets in the register address.

>  #define MAX8907_CTL			0
>  #define MAX8907_SEQCNT			1
>  #define MAX8907_VOUT			2
> @@ -165,6 +210,8 @@
>  #define MAX8907_MASK_OUT5V_ENSRC	0x0E
>  #define MAX8907_MASK_OUT5V_EN		0x01
>  #define MAX8907_MASK_POWER_OFF		0x40
> +#define MAX8907_MASK_RST_CFG_INT_REF_EN	0x01
> +#define MAX8907_MASK_NREF_OK		0x10