Re: [PATCH] coccinelle: api: add a checker for device nodes in devm_ memory
From: Chad Aldreda
Date: Sun Nov 08 2026 - 16:02:10 EST
On Sun, 8 Nov 2026, Julia Lawall wrote:
> I get the same result for
>
> spatch --dir drivers/media/pci/intel/ipu6 scripts/coccinelle/api/devm_file_reachable.cocci -D report --very-quiet
> spatch drivers/media/pci/intel/ipu6/ipu6-isys.c scripts/coccinelle/api/devm_file_reachable.cocci -D report --very-quiet
>
> Both report the line 990 issue.
>
> What version of Coccinelle do you have?
It was 1.1.1, the Ubuntu 24.04 package. With it the --dir run reports
nothing. I built 1.3.3 from git (11b93adb6), and with it both of your
commands report line 990, as does the --include-headers --dir command
from my note, so it was the old version.
Over drivers/ with the script's Options line, 1.3.3 reports one site
more than 1.1.1: drivers/misc/pci_endpoint_test.c, whose probe function
1.1.1 fails to parse. I'll redo the measurements, including the -j
variance, with 1.3.3 for v2.
Thanks for the pointer on the parsing nondeterminism.
Chad