Re: [PATCH 0/2] smb: client: fix DFS handling of non-ASCII paths with non-utf8 charset

[Paulo Alcantara]

Fredric Cover <fredric.cover.lkernel@xxxxxxxxx> writes:

> This series fixes two problems that show up when a DFS mount uses a
> non-utf8 charset (iocharset=iso8859-1, or a kernel built with a
> non-utf8 CONFIG_NLS_DEFAULT) and the DFS path has non-ASCII
> characters.

Applied.

> Known limitation, not addressed here: when a non-ASCII link is
> followed by a path component (e.g. //srv/dfs/café/sub), path_consumed
> is still in utf8 bytes while full_path is in the mount charset, so the
> prefix path is offset incorrectly.  I saw this as -ENOENT.  Patch 1
> only prevents the out-of-bounds access.  Fixing it needs the
> consumed length converted to mount-charset units, which changes the
> dfs_parse_target_referral() interface, so I haven't attempted it.
> Paulo, how would you like that handled?

Please address it with a follow-up patch.  Thanks.