Re: [PATCH net v8 2/4] net: hsr: refuse forwarding devices as HSR/PRP ports

From: Xin Xie

Date: Sun Nov 08 2026 - 17:32:16 EST


The point about cloned data is right: skb_share_check() only
handles a shared skb, but when packet_rcv() or a tc mirror holds a
clone, the TCP/UDP GSO handlers on the RX path still write the checksum
into the shared head. v9 will make the head private with
skb_cow_head(skb, 0) before __skb_gso_segment().

I will check the TX GSO cost on HW tag-insertion offloads and mention
aggregates from older HSR senders as well as older PRP senders in the
v9 message.

v8 also conflicts with Sebastian's pending "hsr: inline PTP header" v10
in net-next; v9 will describe how the two combine.


--
Xin

pw-bot: cr