Re: [PATCH 6/8] reset: rzv2h-usb2phy: Use regmap_test_bits in rzv2h_usbphy_reset_status

[Lad, Prabhakar]

On Tue, Nov 3, 2026 at 2:52 PM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote:
>
> Simplify rzv2h_usbphy_reset_status() by using regmap_test_bits().
> No functional change.
>
> Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> ---
>  drivers/reset/reset-rzv2h-usb2phy.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>

Cheers,
Prabhakar

> diff --git a/drivers/reset/reset-rzv2h-usb2phy.c b/drivers/reset/reset-rzv2h-usb2phy.c
> index d96042e28cd5..e644092cc2f7 100644
> --- a/drivers/reset/reset-rzv2h-usb2phy.c
> +++ b/drivers/reset/reset-rzv2h-usb2phy.c
> @@ -68,11 +68,9 @@ static int rzv2h_usbphy_reset_status(struct reset_controller_dev *rcdev,
>                                      unsigned long id)
>  {
>         struct rzv2h_usb2phy_reset_priv *priv = rzv2h_usbphy_rcdev_to_priv(rcdev);
> -       u32 reg;
>
> -       regmap_read(priv->regmap, priv->data->reset_reg, &reg);
> -
> -       return (reg & priv->data->reset_status_bits) == priv->data->reset_status_bits;
> +       return regmap_test_bits(priv->regmap, priv->data->reset_reg,
> +                               priv->data->reset_status_bits);
>  }
>
>  static const struct reset_control_ops rzv2h_usbphy_reset_ops = {
>
> --
> 2.47.3
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-riscv