Re: [PATCH net v3 4/5] net: mvneta: keep the TX rate limits across open and MTU change

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The commit message for "net: mvneta: keep the TX rate limits
  across open and MTU change" is a bug fix (it has a Fixes: 2551dc9e398c…

--

net: mvneta: keep the TX rate limits across open and MTU change

This patch saves the bucket refill value of each mqprio rate limited TX
queue in struct mvneta_tx_queue. When mvneta_start_dev() runs, it calls
the new mvneta_restore_per_queue_rate_limit() to program those values
again. The reason is that mvneta_txq_hw_init() resets the refill to
10.23 Mbit/s on open, on MTU change and on resume.

> Tested on a Turris Omnia (Armada 385) with 1 Mbit/s limits on a
> 100 Mbit/s link. After the link was set down and up, or the MTU was
> changed, each busy TX queue carried about 10 Mbit/s. With this patch it
> stays at about 1 Mbit/s.
>
> Fixes: 2551dc9e398c ("net: mvneta: Add TC traffic shaping offload")

[Severity: Low]
This isn't a bug, but could the commit message say how the issue was
found? The patch carries a Fixes: tag, and the "Bug fixes" section of
Documentation/process/maintainer-netdev.rst says:

    All bug fixes must state how the issue was discovered and validated,
    and how the fix was tested.

The message explains the validation and names the hardware used for
testing. It doesn't say how the bug was discovered, for example seen in
real use, found by reading the code, or found by a tool. There is also no
Reported-by or similar trailer that would imply it.

The same section also asks for a statement about selftests:

    The testing statement should explain whether the fix was tested against the
    reproducer and against kernel selftests.

Could a line be added saying whether the kernel selftests were run with
this fix?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261104224518.66487-1-pepe.schlehofer%40gmail.com