Re: [PATCH v2] iio: adc: ad4134: Fix duplicate data_read mux state request

From: Marcelo Schmitt

Date: Sun Nov 08 2026 - 20:07:32 EST


On 11/05, Chen Ni wrote:
> devm_mux_state_get() is called twice in a row. The second call's result
> is stored directly into st->mux_st[AD4134_DOUT0_INPUT] without error
> checking, and then immediately overwritten by the first call's result.
>
> Remove the duplicate call and check the return value before saving the
> state.
>
> Fixes: f12ecb3e147b ("iio: adc: ad4134: Support SPI 4-wire mode")
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
> Reviewed-by: Joshua Crofts <crofts@xxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> ---
LGTM
If still worth anything,
Reviewed-by: Marcelo Schmitt <marcelo.schmitt1@xxxxxxxxx>

Thanks,
Marcelo