Re: [PATCH 4/4] arm64: dts: cix: add RTS5453 PD controllers to Orion O6
From: Gary Yang
Date: Sun Nov 08 2026 - 21:11:32 EST
hi Krzysztof:
Thanks for your comments!
On 2026-11-07 11:53, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
>
> On 07/11/2026 02:10, Gary Yang wrote:
> > Describe the two Realtek RTS5453H port controllers on the Orion O6
> > I2C1 bus and add the I2C1 pin configuration.
> >
> > The controllers route orientation and DisplayPort mode changes
> > through the USB/DP combo PHY lane switches, but that PHY support is
> > not upstream yet, so the connector graph endpoints are left out for
> > now. The Type-C ports are still registered and reported, only the
> > lane switching is deferred until the PHY nodes are available.
> >
> > Both controllers report through the same level-triggered interrupt
> > line, which the driver handles with a shared interrupt. The I2C bus
> > runs at 100 kHz because the RTS5453H I2C interface does not support
> > higher rates.
> >
> > Signed-off-by: Gary Yang <gary.yang@xxxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/cix/sky1-orion-o6.dts | 51 +++++++++++++++++++++++
> > 1 file changed, 51 insertions(+)
>
> DTS cannot be combined in this patchset and must be split. Don't mix
> patches from independent subsystems when you send something explicitly
> targeting only one subsystem.
> See also: Documentation/devicetree/bindings/submitting-patches.rst
>
Do you mean the driver does not depend on DTS? Previously, it was acceptable
to put the DTS at the end of a patchset or place the DTS in a separate patchset.
That’s why I put the DTS at the end of the patchset. Has the rule changed now?
Best Regards,
Gary
>
> Best regards,
> Krzysztof