Re: [PATCH v2 06/10] ASoC: fsl_sai: Warn if TE/RE does not clear on disable

[Bui Duc Phuc]

Hi Mark,

Thank you for your reviews.

> > +     if (ret == -ETIMEDOUT)
> > +             dev_warn(&sai->pdev->dev, "%cx not disabled at frame end\n",
>
> There wasn't a warning before...
>
> > +     else if (ret)
> > +             dev_err(&sai->pdev->dev, "failed to read %cSCR : %d\n",
>

That's correct. Since this function returns void, previous failures and
abnormal hardware conditions were silently ignored. I added a warning
for timeouts and an error message for regmap read failures to make
these issues visible and easier to diagnose.

Best regards,
Phuc