Re: [PATCH 1/2] dt-bindings: serial: 8250: add Microchip Core16550
From: Kohei Otsuka
Date: Sun Nov 08 2026 - 21:54:37 EST
On Thu, Nov 5, 2026 at 3:20 AM Conor Dooley <conor@xxxxxxxxxx> wrote:
>
> On Tue, Nov 03, 2026 at 11:11:31AM +1100, Kohei Otsuka wrote:
> > Core16550 is a 16550-compatible UART soft IP core for Microchip FPGAs,
> > including the fabric of PolarFire SoC. Its registers follow the 16550A,
> > so ns16550a stays the fallback, but
>
> > it raises no interrupt on TEMT,
> > which the driver has to know about to support RS-485 on it.
>
> Doesn't this exclude using the fallback to ns16550a, since it requires
> specific interrupt handling?
>
Everything a plain ns16550a driver does works on
Core16550 including transmit, receive, FIFOs, modem control and the baud rate
divisor. The only thing that needs the specific compatible string is
software RS-485
(em485), which waits for a TEMT interrupt the core doesn’t raise.
Without the patch, RS-485 direction control is missing, but the UART
otherwise works. If you’d rather
not have the fallback, I can match the compatible in 8250_of directly.
> >
> > Add microchip,core16550 with ns16550a as the fallback.
> >
> > Link: https://github.com/linux4microchip/meta-mchp/issues/5
> > Signed-off-by: Kohei Otsuka <kohei@xxxxxxxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/serial/8250.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> > index 50d5c977afa3..33a5929bdaa6 100644
> > --- a/Documentation/devicetree/bindings/serial/8250.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> > @@ -137,6 +137,7 @@ properties:
> > - ti,da830-uart
> > - loongson,ls2k0500-uart
> > - loongson,ls2k1500-uart
> > + - microchip,core16550
>
> This needs a -rtl-vX suffix on the end, as is used for other fabric
> cores - see microchip,corei2c.yaml for an example.
>
v2 will use microchip,core16550-rtl-v3, thanks.
> pw-bot: changes-requested
>
> Thanks,
> Conor.
>
> > - const: ns16550a
> > - items:
> > - enum:
> >
> > --
> > 2.53.0
> >
--
Kohei Otsuka
Satellite Flight Software Team Lead
koheio@xxxxxxxxxxxxxxxxx spacemachines.com
UTS Tech Lab, 36-38 Lord Street, Botany NSW 2019