Re: [PATCH 5/5] ASoC: dwc: Remove redundant error messages

[Bui Duc Phuc]

Hi Mark,

Thank you for your review.

>
> > The underlying functions already report these errors deeper in
> > the call chain, making the additional dev_err_probe() and
> > dev_err() calls unnecessary.
>
> >               ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
> >                               pdev->name, dev);
> > -             if (ret < 0) {
> > -                     dev_err(&pdev->dev, "failed to request irq\n");
> > +             if (ret < 0)
> >                       goto err_assert_reset;
>
> request_irq() logs some failures, but not those where the interrupt is
> just missing.


I understand.
With platform_get_irq_optional(), a missing IRQ is not considered an error,
so no error message is expected in that case.

To handle other IRQ retrieval errors explicitly, I'll update the code
as follows:

------------------------------------------------------------------------------------------
irq = platform_get_irq_optional(pdev, 0);
if (irq < 0 && irq != -ENXIO)
        return dev_err_probe(&pdev->dev, irq, "failed to get IRQ\n");

if (irq > 0) {
        ret = devm_request_irq(&pdev->dev, irq, i2s_irq_handler, 0,
                                               pdev->name, dev);
        if (ret)
                goto err_assert_reset;
}
-------------------------------------------------------------------------------------------

Best regards,
Phuc