Re: [PATCH 2/5] gpio: aspeed-sgpio: propagate IRQ setup error in probe

[Andrew Jeffery]

On Sat, 2026-11-07 at 16:12 +0800, shao.mingyin@xxxxxxxxxx wrote:
> From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
> 
> aspeed_sgpio_probe() ignores the return value of
> aspeed_sgpio_setup_irqs().  That function returns the result of
> platform_get_irq(), so on failure - in particular -EPROBE_DEFER while
> the parent interrupt controller is still probing - the driver carries on
> and registers the gpiochip with no interrupt support, and the deferred
> probe is never retried, leaving GPIO interrupts permanently broken.
> 
> The "interrupts" property is mandatory for this device, so propagate the
> error from probe.
> 
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>