Re: [PATCH v3] arm64: ptrace: don't warn on missing siginfo in a group-stop
From: Zhao Gongyi
Date: Sun Nov 08 2026 - 23:12:01 EST
Hi Oleg,
Thanks for the review and Acked-by.
On 11/9/26 2:59 AM, Oleg Nesterov wrote:
>
> ----------------------------------------------------------------------------
> But can't resist... The old comment was obviously wrong, the new one doesn't
> look clear to me. It correctly explains why info can be NULL, but not why we
> should not update orig_x0 in this case. May be it should just say that exit-stop
> always comes with info != NULL?
>
You're right: the comment explains why info can be NULL, but not why we
return. The early return is intentional: it keeps orig_x0 unchanged
during a non-seized group-stop. I'll wait for Catalin and Will's
thoughts on the wording.
Thanks,
Gongyi