Re: [PATCH v4 0/5] drm/imagination: RISC-V and META firmware interface updates
From: Brajesh Gupta
Date: Mon Nov 09 2026 - 00:20:47 EST
On Tue, 2026-11-03 at 11:00 +0200, Alexandru Dadu wrote:
Hi Dadu,
> Refactor RISC-V and META firmware interface headers to have a more
> generic and architecture independent approach:
> 1. Limits access to the RISC-V and META firmware respective interfaces.
> 2. Aligns RISC-V and META firmware headers with the other processor
> headers.
> 3. Add "_fw_" component to the headers filename.
>
> Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
> ---
> Changes in v4:
> - Fixed a bug introduced by the previous update to layout_is_mars().
> - Link to v3: https://patch.msgid.link/20261103-prep-meta-fw-arch-independent-v3-0-563dbaf1b779@xxxxxxxxxx
>
> Changes in v3:
> - Fixed remarks raised by Sashiko in pvr_fw_startstop.c.
> - Link to v2: https://patch.msgid.link/20261029-prep-meta-fw-arch-independent-v2-0-b9f5d69b7a52@xxxxxxxxxx
>
> Changes in v2:
> - Update the commit messages to better describe the changes.
> - Link to v1: https://patch.msgid.link/20261028-prep-meta-fw-arch-independent-v1-0-73e116f02172@xxxxxxxxxx
>
> To: Alessio Belle <alessio.belle@xxxxxxxxxx>
> To: Luigi Santivetti <luigi.santivetti@xxxxxxxxxx>
> To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> To: Maxime Ripard <mripard@xxxxxxxxxx>
> To: Thomas Zimmermann <tzimmermann@xxxxxxx>
> To: David Airlie <airlied@xxxxxxxxx>
> To: Simona Vetter <simona@xxxxxxxx>
> To: Paul Walmsley <pjw@xxxxxxxxxx>
> To: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> To: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> To: Alexandre Ghiti <alex@xxxxxxxx>
> Cc: imagination@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-riscv@xxxxxxxxxxxxxxxxxxx
>
> ---
> Alessio Belle (4):
> drm/imagination: Limit access to the RISC-V firmware interface
> drm/imagination: Make the RISC-V firmware header arch-independent
> drm/imagination: Limit access to the META firmware interface
> drm/imagination: Make the META firmware header arch-independent
>
> Alexandru Dadu (1):
> drm/imagination: Prepare heap config header for multi-arch support
>
For the whole series,
Reviewed-by: Brajesh Gupta <brajesh.gupta@xxxxxxxxxx>
Thanks,
Brajesh
> drivers/gpu/drm/imagination/pvr_fw.c | 7 +-
> drivers/gpu/drm/imagination/pvr_fw.h | 26 +++
> drivers/gpu/drm/imagination/pvr_fw_meta.c | 104 +++++++-----
> drivers/gpu/drm/imagination/pvr_fw_meta.h | 14 --
> .../{pvr_rogue_meta.h => pvr_fw_meta_internal.h} | 175 +++++++++++----------
> drivers/gpu/drm/imagination/pvr_fw_mips.c | 1 +
> drivers/gpu/drm/imagination/pvr_fw_riscv.c | 13 +-
> .../gpu/drm/imagination/pvr_fw_riscv_internal.h | 43 +++++
> drivers/gpu/drm/imagination/pvr_fw_startstop.c | 61 +++----
> drivers/gpu/drm/imagination/pvr_gem.h | 3 +-
> .../{pvr_rogue_heap_config.h => pvr_heap_config.h} | 26 +--
> drivers/gpu/drm/imagination/pvr_rogue_riscv.h | 39 -----
> drivers/gpu/drm/imagination/pvr_vm.c | 18 +--
> 13 files changed, 289 insertions(+), 241 deletions(-)
> ---
> base-commit: 6e375de99d0c420169481fcd36064177ab55b09d
> change-id: 20261028-prep-meta-fw-arch-independent-ffd6dcd626d0
>
> Best regards,
> --
> Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
>