[PATCH v2] tools/leds/uledmon: reject device names that are too long

From: Gu Bin

Date: Mon Nov 09 2026 - 02:06:02 EST


strncpy() does not NUL-terminate when the source is at least as long
as the bound. uleds_dev.name is passed to the kernel with
write(fd, &uleds_dev, sizeof(uleds_dev)), so a >= LED_MAX_NAME_SIZE
byte argv[1] leaves name without a terminator and the write sends
trailing bytes that are not part of a valid device name.

Silently truncating such a name would create a device the user did
not ask for, so error out instead, like the other argument checks
already do.

Fixes: fa7f32422ea1 ("tools/leds: Add uledmon program for monitoring userspace LEDs")
Suggested-by: David Lechner <david@xxxxxxxxxxxxxx>
Signed-off-by: Gu Bin <gubin@xxxxxxxxxxxxxxxxxxxx>
---

Changes in v2: reject over-long names with an error instead of
silently truncating them, as suggested by David Lechner.

tools/leds/uledmon.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/leds/uledmon.c b/tools/leds/uledmon.c
index c15a39c1f271..d38f5716c7f7 100644
--- a/tools/leds/uledmon.c
+++ b/tools/leds/uledmon.c
@@ -31,7 +31,13 @@ int main(int argc, char const *argv[])
return 1;
}

- strncpy(uleds_dev.name, argv[1], LED_MAX_NAME_SIZE);
+ if (strlen(argv[1]) >= LED_MAX_NAME_SIZE) {
+ fprintf(stderr, "Device name too long (max %d bytes)\n",
+ LED_MAX_NAME_SIZE - 1);
+ return 1;
+ }
+
+ strcpy(uleds_dev.name, argv[1]);
uleds_dev.max_brightness = 100;

fd = open("/dev/uleds", O_RDWR);
--
2.55.0.windows.3