Re: [PATCH v2] staging: media: atomisp: Clarify MIPI frame layout comment

From: Andy Shevchenko

Date: Mon Nov 09 2026 - 02:17:35 EST


On Mon, Nov 9, 2026 at 8:12 AM Lame Morupisi <lamemorupisi12@xxxxxxxxx> wrote:
>
> Clarify the description of the MIPI frame memory layout by
> explaining the meaning of optional fields and payload words.
>
> Leave the frame layout diagram unchanged to preserve its
> existing representation.

...

> - /* a frame represented in memory: ()- optional; data - payload words.
> + /* Frame representation in memory: () denotes optional fields;
> + * data denotes payload words.

This uses the wrong multi-line comment style.

...

And as Dan said, you missed changelog to explain. (But in any case
neither v1 nor v2 is good to go.)

--
With Best Regards,
Andy Shevchenko