Re: [PATCH 3/5] ASoC: dwc: Fix channels_max derived from COMP_PARAM_1

[Maxim Kochetkov]

06.11.2026 14:29, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> The I2S_TX_CHANNELS (bits 10:9) and I2S_RX_CHANNELS (bits 8:7) fields
> of I2S_COMP_PARAM_1 encode the number of hardware channels minus one,
> i.e. values 0..3 mean 1..4 channels. In I2S mode each hardware channel
> is one serial data line carrying a left/right pair, so the maximum
> number of audio channels is 2 * (N + 1).
>
> The current code uses 1 << (N + 1), which only produces the correct
> result for N < 2. For N >= 2, it overestimates the maximum number of
> audio channels.
>
> Use 2 * (N + 1) for both playback and capture.
>
> Fixes: b226efe5818b ("ASoC: dwc: Read I2S block configuration from registers")
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>

Reviewed-by: Maxim Kochetkov <fido_max@xxxxxxxx>