Re: [PATCH rtw-next v2 7/7] wifi: rtw88: 8812a, 8821a: respect peer A-MPDU size limits
From: Luka Gejak
Date: Mon Nov 09 2026 - 02:25:53 EST
Hi Jie Feng,
On November 8, 2026 7:09:40 PM GMT+01:00, Jie Feng <hjf3108@xxxxxxxxx>
wrote:
>On Sat, 7 Nov 2026 at 00:35, Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
>> This is the same as rtw8812a_set_ampdu_factor() apart from the limit.
>> Maybe a single rtw88xxa_set_ampdu_factor() that picks the limit by chip
>> id, like rtw88xxa_set_crystal_cap() in patch 5 does for the mask?
> I feel that this one would not deduplicate much code and defeats the
> point of a
> per chip set_ampdu_factor callback anyway.
Fair enough. It is only two lines, and a shared helper would need an
export and a chip id check on top, so keeping them separate is fine
with me.
Best regards,
Luka Gejak