Re: [PATCH v5 0/4] drm/imagination: Clean up MIPS firmware interfaces

[Brajesh Gupta]

On Mon, 2026-11-02 at 09:08 +0200, Alexandru Dadu wrote:
Hi Dadu,
> 1. Limits access to the MIPS firmware interface, keeping its state
>    within the relevant implementation.
> 2. Align MIPS firmware headers with the other processor headers and add
>    "_fw_" component to the headers filename.
> 3. Improved logging in error paths.
> 4. Simplify MIPS PTE definitions.
> 
> Signed-off-by: Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
> ---
For the whole series,
Reviewed-by: Brajesh Gupta <brajesh.gupta@xxxxxxxxxx>

Thanks,
Brajesh
> Changes in v5:
> - Update documentation for pvr_fw_device struct (pointed out by Sashiko).
> - Link to v4: https://patch.msgid.link/20261029-b4-simplify-mips-pte-defs-v4-0-9656041e040b@xxxxxxxxxx
> 
> Changes in v4:
> - Update the commit messages to better describe the changes.
> - Link to v3: https://patch.msgid.link/20261026-b4-simplify-mips-pte-defs-v3-0-587087d8a284@xxxxxxxxxx
> 
> Changes in v3:
> - Squash a commit that ads "_fw_" component to the MIPS firmware headers filename. 
> - Link to v2: https://patch.msgid.link/20261022-b4-simplify-mips-pte-defs-v2-0-ee2402c03a4b@xxxxxxxxxx
> 
> Changes in v2:
> - propagate the commit update to PVR_MIPSFW_TLB_GET_PA().
> - removed the RISC-V group from the target group of this update.
> - Link to v1: https://patch.msgid.link/20261014-b4-simplify-mips-pte-defs-v1-0-b4ad7bb68e22@xxxxxxxxxx
> 
> To: Alessio Belle <alessio.belle@xxxxxxxxxx>
> To: Luigi Santivetti <luigi.santivetti@xxxxxxxxxx>
> To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>
> To: Maxime Ripard <mripard@xxxxxxxxxx>
> To: Thomas Zimmermann <tzimmermann@xxxxxxx>
> To: David Airlie <airlied@xxxxxxxxx>
> To: Simona Vetter <simona@xxxxxxxx>
> To: Paul Walmsley <pjw@xxxxxxxxxx>
> To: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> To: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
> To: Alexandre Ghiti <alex@xxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: imagination@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> 
> ---
> Alessio Belle (2):
>       drm/imagination: Limit access to the MIPS firmware interface
>       drm/imagination: Make the MIPS firmware headers arch-independent
> 
> Matt Coster (2):
>       drm/imagination: Improve some logging in error paths
>       drm/imagination: Simplify MIPS PTE definitions
> 
>  drivers/gpu/drm/imagination/pvr_fw.c               |   6 +-
>  drivers/gpu/drm/imagination/pvr_fw.h               |  11 +-
>  drivers/gpu/drm/imagination/pvr_fw_mips.c          |  79 +++--
>  drivers/gpu/drm/imagination/pvr_fw_mips.h          |  49 ---
>  drivers/gpu/drm/imagination/pvr_fw_mips_internal.h | 309 +++++++++++++++++++
>  .../drm/imagination/pvr_fw_mips_internal_check.h   |  35 +++
>  drivers/gpu/drm/imagination/pvr_fw_riscv.c         |   1 -
>  drivers/gpu/drm/imagination/pvr_rogue_mips.h       | 335 ---------------------
>  drivers/gpu/drm/imagination/pvr_rogue_mips_check.h |  35 ---
>  drivers/gpu/drm/imagination/pvr_vm_mips.c          | 162 +++++++---
>  drivers/gpu/drm/imagination/pvr_vm_mips.h          |   2 +
>  11 files changed, 519 insertions(+), 505 deletions(-)
> ---
> base-commit: 6e375de99d0c420169481fcd36064177ab55b09d
> change-id: 20261014-b4-simplify-mips-pte-defs-e2be1f613d14
> 
> Best regards,
> --  
> Alexandru Dadu <alexandru.dadu@xxxxxxxxxx>
>