Re: [PATCH 3/5] gpio: ppc44x: fold __ppc44x_gpio_set() into ppc44x_gpio_dir_out()

[Bartosz Golaszewski]

On Wed, Nov 04, 2026 at 01:59:57PM -0800, Rosen Penev wrote:
> __ppc44x_gpio_set() has a single caller, and it looks up the driver
> data that the caller already has. Open-code it in the direction_output
> callback, with a comment explaining why gpio_generic_chip_set() can't
> be used there: the generic setter takes the chip lock, which is already
> held at that point.
> 
> While at it, drop the pr_debug(); gpiolib's tracepoints already report
> direction and value changes.
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
 
Sigh... This is really just churn...

I'll take it with the rest of the series as sashiko doesn't seem to
complain but this time would be better spent elsewhere. If you like
fixing bugs, I can assign you a number of GPIO bugs sashiko found.

Bart