Re: [PATCH v5 4/8] irqchip/realtek-intc-common: Add basic support for Realtek DHC SoCs

[Thomas Gleixner]

On Mon, Oct 19 2026 at 00:06, Yu-Chun Lin wrote:
> +static bool realtek_intc_dispatch(struct realtek_intc_subset_data *subset_data)
> +{
> +	const struct realtek_intc_info *bank_info = subset_data->bank_info;
> +	struct realtek_intc_data *data = subset_data->common;
> +	u32 ints, inte, mask, val;
> +	irq_hw_number_t hwirq;
> +	bool handled = false;
> +	int irq;
> +
> +	if (regmap_read(data->base, bank_info->isr_offset, &val))
> +		return false;
> +
> +	ints = val & subset_data->subset_mask->ints_mask;
> +
> +	if (!ints)
> +		return false;
> +
> +	if (regmap_read(data->base, bank_info->scpu_int_en_offset, &inte))
> +		return false;
> +
> +	while (ints) {
> +		irq = __ffs(ints);
> +		ints &= ~BIT(irq);
> +
> +		mask = bank_info->isr_to_scpu_int_en_mask[irq];
> +		if (mask != IRQ_ALWAYS_ENABLED && !(inte & mask))
> +			continue;
> +
> +		hwirq = (subset_data->bank_idx * 32) + irq;
> +
> +		if (!generic_handle_domain_irq(data->domain, hwirq))

You might want to use generic_handle_demux_domain_irq() which allows you
to implement affinity setting for the individual demultiplexed interrupts/

> +static void realtek_intc_handler(struct irq_desc *desc)
> +{
> +	struct realtek_intc_subset_data *subset_data = irq_desc_get_handler_data(desc);
> +	struct irq_chip *chip = irq_desc_get_chip(desc);
> +
> +	chained_irq_enter(chip, desc);

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=6cf0d999a18e799965cf2cf4a0157e257c805946

> +	realtek_intc_dispatch(subset_data);
> +
> +	chained_irq_exit(chip, desc);
> +}

> +int realtek_intc_probe(struct platform_device *pdev, const struct realtek_intc_desc *desc)
> +{
> +	struct realtek_intc_data *data;
> +	struct device *dev = &pdev->dev;
> +	struct device_node *node = dev->of_node;
> +	unsigned int total_subset_num = 0;
> +	int ret, parent_irq = 0;
> +
> +	for (unsigned int i = 0; i < desc->bank_num; i++)
> +		total_subset_num += desc->banks[i].subset_num;
> +
> +	data = devm_kzalloc(dev, struct_size(data, subset_data, total_subset_num),
> +			    GFP_KERNEL);
> +	if (!data)
> +		return -ENOMEM;
> +
> +	data->saved_en = devm_kcalloc(dev, desc->bank_num, sizeof(*data->saved_en), GFP_KERNEL);
> +	if (!data->saved_en)
> +		return -ENOMEM;
> +
> +	data->base = syscon_node_to_regmap(node->parent);
> +	if (IS_ERR(data->base))
> +		return PTR_ERR(data->base);
> +
> +	data->desc = desc;
> +
> +	data->domain = irq_domain_create_linear(of_fwnode_handle(node),
> +						32 * desc->bank_num,
> +						&realtek_intc_domain_ops, data);

https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=irq/drivers&id=51987720c2845807161f56f4714df4562f56f328

> +	if (!data->domain)
> +		return -ENOMEM;

Thanks,

        tglx