Re: [PATCH v2] media: ipu6: declare firmware files with MODULE_FIRMWARE

[Sakari Ailus]

Hi,

On Sat, Nov 07, 2026 at 09:04:40PM -0800, DelaySystem via B4 Relay wrote:
> From: DelaySystem <DelaySystem@xxxxxxxxx>
> 
> The driver requests one of eight firmware blobs at runtime depending on
> the detected SoC (IPU6, IPU6SE, IPU6EP, IPU6EPADLN, IPU6EPMTL, IPU7,
> IPU7P5 or IPU8), selected through isp->cpd_fw_name, but never declares
> them.  As a result modinfo shows no firmware: lines and initramfs
> generators cannot pick up the dependency automatically.
> 
> Add MODULE_FIRMWARE() for every blob the driver can request.
> 
> Suggested-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/apqB28RBDZV4BlDZ@kekkonen.localdomain/
> Signed-off-by: DelaySystem <DelaySystem@xxxxxxxxx>

Could we have a real name here? Same for From:.

> ---
> Changes in v2:
> - Resend with corrected Cc list (v1 accidentally reached only Sakari and linux-kernel: repeated --cc flags do not accumulate in b4); no code change.
> - Adds linux-media@xxxxxxxxxxxxxxx and Mauro Carvalho Chehab to Cc.
> - Link to v1: https://patch.msgid.link/20261107-batch1-s1-ipu6-fw-v1-1-1d5323aff7b2@xxxxxxxxx
> ---
>  drivers/media/pci/intel/ipu6/ipu6.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6.c b/drivers/media/pci/intel/ipu6/ipu6.c
> index cdf812c02960..ec2a9c2bf587 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6.c
> @@ -1028,3 +1028,11 @@ MODULE_AUTHOR("Yunliang Ding <yunliang.ding@xxxxxxxxx>");
>  MODULE_AUTHOR("Hongju Wang");
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Intel IPU6 PCI driver");
> +MODULE_FIRMWARE(IPU6SE_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU6EP_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU6_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU6EPMTL_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU6EPADLN_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU7_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU7P5_FIRMWARE_NAME);
> +MODULE_FIRMWARE(IPU8_FIRMWARE_NAME);
> 

-- 
Regards,

Sakari Ailus