[PATCH] hwmon: (nct6775) Clamp voltage limits before narrowing and scaling

From: Zhu Jun

Date: Mon Nov 09 2026 - 04:38:32 EST


From: zhujun <zhujun2@xxxxxxxxxxxxxxxxxxxx>

store_in_reg() parses an unsigned long, but in_to_reg() takes a u32 and
multiplies it by 100 before clamping. Large limits can therefore wrap to
a low register value. For example, 4294967296 mV becomes zero on a
64-bit system.

Keep the input as an unsigned long and bound it to the register range
before scaling.

Fixes: 9de2e2e84e7d ("hwmon: Driver for Nuvoton NCT6775F, NCT6776F, and NCT6779D")
---
Validation: x86-64 and i386 driver objects built with W=1.
Source-extracted boundary tests passed on 32-bit and 64-bit;
the corresponding test fails on the base revision. I/O is mocked.
No physical sensor hardware or booted-kernel test was available.
OpenAI Codex assisted analysis, code, tests and changelog drafting.
The human submitter must review and add their Signed-off-by.

drivers/hwmon/nct6775-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/hwmon/nct6775-core.c b/drivers/hwmon/nct6775-core.c
index 6e97e4f08b90..b7c1e8ceaac9 100644
--- a/drivers/hwmon/nct6775-core.c
+++ b/drivers/hwmon/nct6775-core.c
@@ -1039,8 +1039,9 @@ static inline long in_from_reg(u8 reg, u8 nr, const u16 *scales)
return DIV_ROUND_CLOSEST(reg * scales[nr], 100);
}

-static inline u8 in_to_reg(u32 val, u8 nr, const u16 *scales)
+static inline u8 in_to_reg(unsigned long val, u8 nr, const u16 *scales)
{
+ val = min(val, 255UL * scales[nr] / 100);
return clamp_val(DIV_ROUND_CLOSEST(val * 100, scales[nr]), 0, 255);
}


base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
--
2.51.0