Re: [PATCH] irqchip/riscv-aplic: Process pending affinity changes on EOI

From: Thomas Gleixner

Date: Mon Nov 09 2026 - 05:17:34 EST


On Wed, Nov 04 2026 at 14:21, Troy Mitchell wrote:
> IMSIC rejects an affinity change with -EBUSY while a previous vector
> move is still in flight, and the IRQ core then records the new mask as
> pending. The change is meant to be applied by irq_move_irq() in the
> IMSIC irq_ack callback, but APLIC MSI interrupts are handled by
> handle_fasteoi_irq(), which does not call irq_ack.

Which is a bug when the interrupt is edge type.

Edge type interrupts are fire and forget from the device point of
view. So you want handle_edge_irq() for them, which issues the ack()
_before_ the handler is invoked. Otherwise you can lose interrupts.

Thanks,

tglx