Re: [PATCH v3 1/4] dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0

[Benjamin Mugnier]

Hi Sergey,

Le 09/11/2026 à 10:34, Sergey Lebedev a écrit :
> The VD55G0 is a monochrome global shutter sensor with a 644x604 active
> array, sending over a single MIPI CSI-2 lane, with the same supplies,
> reset and strobe GPIOs as the VD55G1. Its MIPI rate runs from 750 to
> 1200 Mbps (UM2829, 13.1), so its link frequency starts at 375 MHz, and
> its I2C address is set in its NVM rather than fixed.
> 
> allOf moves below required to carry the if/then for that minimum.
> 
> Signed-off-by: Sergey Lebedev <lsa.uz@xxxxx>
> ---
> v3: no change.
> 
> v2: the VD55G0 joins this file instead of a st,vd55g0.yaml of its own,
> with allOf below required for the if/then, as Krzysztof pointed to. It
> is Peter Marshall's 01/11 and 02/11 of his vd55g1 v2 squashed, as
> Krzysztof asked there, with the VD55G0's description added:
> https://lore.kernel.org/all/20260918221705.323510-3-pm@xxxxxxxxxxxxxxxx/

As vd55g1 and vd55g0 are two different drivers I think they should be
kept separated. Not sure what Krzysztof meant, maybe he just wanted to
point to a similar patchset. Krzysztof coud you clarify ?

Could this patch be reverted to v1 ? I see that similarly the
MAINTAINERS file as also been altered in the second patch.

> 
>  .../bindings/media/i2c/st,vd55g1.yaml         | 27 ++++++++++++++++---
>  1 file changed, 23 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml b/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml
> index dfd87beba06..0245673d105 100644
> --- a/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/st,vd55g1.yaml
> @@ -16,21 +16,23 @@ description: |-
>   array size of 804H x 704V. It is programmable through I2C interface. The I2C
>   address is fixed to 0x10.
>  
> + The VD55G0 is a monochrome global shutter image sensor with an active array
> + size of 644H x 604V, programmable through I2C at an address set in its NVM.
> +
>   Image data is sent through MIPI CSI-2, which is configured as only 1 data
>   lane. The sensor provides 4 GPIOS that can be used for external LED signal
>   (synchronized with sensor integration periods).
>  
> -allOf:
> -  - $ref: /schemas/media/video-interface-devices.yaml#
> -
>  properties:
>    compatible:
>      enum:
> +      - st,vd55g0
>        - st,vd55g1
>        - st,vd55g4
>        - st,vd65g4
>      description:
> -      VD55G1 and VD55G4 are monochrome variants, while VD65G4 is a color one.
> +      VD55G0, VD55G1 and VD55G4 are monochrome variants, while VD65G4 is a
> +      color one.
>  
>    reg:
>      maxItems: 1
> @@ -101,6 +103,23 @@ required:
>    - reset-gpios
>    - port
>  
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: st,vd55g0
> +    then:
> +      properties:
> +        port:
> +          properties:
> +            endpoint:
> +              properties:
> +                link-frequencies:
> +                  items:
> +                    minimum: 375000000
> +
>  unevaluatedProperties: false
>  
>  examples:

-- 
Regards,
Benjamin