Re: [PATCH] ASoC: fsl_asrc_dma: fix error handling for DMA channel retrieval

[Chancel Liu]

On 11/8/2026 12:00 AM, Mark Brown wrote:
> On Fri, Nov 06, 2026 at 01:50:46PM +0800, Chancel Liu wrote:
>> On 10/28/2026 10:59 AM, shengjiu.wang@xxxxxxxxxxx wrote:
>>> From: Shengjiu Wang <shengjiu.wang@xxxxxxx>
>>>
>>> The original check used `if (!tmp_chan)`, which only catches NULL pointers.
>>> However `asrc->get_dma_channel()` returns an error pointer. The NULL check
>>> will always succeed, so replace it with `IS_ERR(tmp_chan)` to correctly
>>> detect errors.
>>>
>>> Fixes: b4136c0d69ea ("ASoC: fsl_asrc: check the second front-end DMA channel")
>>> Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
>>
>> Reviewed-by: Chancel Liu <chancel.liu@xxxxxxxxx>
> 
> Note that if you send from an address other than the one you're using
> for your R-b it'll be ignored by the tooling.

Oh, I never knew that. Thanks for the reminder!

Regards,
Chancel Liu