Re: [PATCH v2 1/4] dt-bindings: dsp: fsl,dsp: document debug reset control

[Shengjiu Wang]

On Mon, Nov 9, 2026 at 3:40 PM Shengjiu Wang <shengjiu.wang@xxxxxxxxx> wrote:
>
> On Mon, Nov 9, 2026 at 3:29 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> >
> > On 09/11/2026 03:22, Shengjiu Wang wrote:
> > > On Fri, Nov 6, 2026 at 8:57 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> > >>
> > >> On Thu, Nov 05, 2026 at 10:41:03AM +0800, shengjiu.wang@xxxxxxxxxxx wrote:
> > >>> From: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > >>>
> > >>> The HiFi4 DSP provides a separate reset control for its debug logic.
> > >>> Keep this reset deasserted so that an external debug agent can access
> > >>> the DSP and perform debug operations.
> > >>>
> > >>> Also require the reset properties for the i.MX8ULP HiFi4 DSP.
> > >>
> > >> That's ABI break without explanation.
> > >>
> > >
> > > The i.MX8ULP HiFi4 DSP has not been enabled upstream before. This series
> > > adds the DSP node for the first time, so there should be no existing upstream
> > > DT relying on this compatible without the reset properties.
> >
> > That does not change the fact that you break ABI, does it?
> >
>
> Yes, it changes the binding ABI. However, these reset controls are
> required for the
>  i.MX8ULP HiFi4 DSP to work correctly, so the existing binding is
> incomplete without
>  them. I will add this explanation to the commit message.
>

I also think it would be better to split the i.MX8ULP reset requirement
into a separate patch. Does that make sense to you?

Best regards
Shengjiu Wang