Re: [PATCH 4/9] device property: provide fwnode_property_get_names()

[Bartosz Golaszewski]

On Wed, Nov 04, 2026 at 11:17:37PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 04, 2026 at 03:03:46PM +0100, Bartosz Golaszewski wrote:
> 
> > + */
> > +int fwnode_property_get_names(const struct fwnode_handle *fwnode, char ***props)
> 
> Triple indirection is rare. Do we really need it?
> 

I don't have a better alternative. Having two functions: one for
counting the names and another for retrieving them into a
caller-provided array is IMO the worse alternative, so I'd keep it.

> 
> > +	merged = kcalloc(n1 + n2, sizeof(*merged), GFP_KERNEL);
> 
> Shouldn't here be something from overflow.h?
>

I guess size_add() would fit.

Ok for other comments.

Bart