Re: [PATCH RESEND v2 07/23] proc: let procfs own the seq_file of seq_file entries
From: Christian Brauner
Date: Mon Nov 09 2026 - 06:29:59 EST
On Sat, Nov 07, 2026 at 08:10:28AM -0800, Kees Cook wrote:
> Please use the new style typed allocation calls for objects:
>
> ops = kmalloc_obj(*ops);
>
> (This happened to jump out at me, but please check the other patches for this pattern.)
Done, there are 5 of them in total:
proc: resume readdir after the last name it returned
- cursor = kmalloc(sizeof(*cursor), GFP_KERNEL_ACCOUNT);
+ cursor = kmalloc_obj(*cursor, GFP_KERNEL_ACCOUNT);
proc: sysctl: resume readdir after the last name it returned
- cursor = kmalloc(sizeof(*cursor), GFP_KERNEL_ACCOUNT);
+ cursor = kmalloc_obj(*cursor, GFP_KERNEL_ACCOUNT);
proc: keep the open files of an entry in an open node
- dp->open = kzalloc(sizeof(*dp->open), GFP_KERNEL);
+ dp->open = kzalloc_obj(*dp->open);
proc: own the wait queue of an entry with a ->proc_poll()
- on = kzalloc(sizeof(*on), GFP_KERNEL);
+ on = kzalloc_obj(*on);
proc: let procfs own the seq_file of seq_file entries
- ops = kmalloc(sizeof(*ops), GFP_KERNEL);
+ ops = kmalloc_obj(*ops);
--