Re: [PATCH v3 6/9] drm/vc4: hdmi: Convert to common HDMI 2.0 scrambling infrastructure
From: Cristian Ciocaltea
Date: Mon Nov 09 2026 - 07:25:15 EST
Hi Maíra,
On 11/9/26 1:53 PM, Maíra Canal wrote:
> Hi Cristian,
>
> On 04/11/26 17:08, Cristian Ciocaltea wrote:
>> On 10/28/26 11:44 PM, Cristian Ciocaltea wrote:
>>> Hi Maíra,
>>>
>>> On 10/27/26 3:35 PM, Maíra Canal wrote:
>>>> Hi Cristian,
>>>>
>>>> On 13/10/26 22:03, Cristian Ciocaltea wrote:
>>>>> Replace driver local scrambling logic with the newly introduced common
>>>>> HDMI 2.0 scrambling support:
>>>>>
>>>>> - Advertise source-side scrambling capability by setting supported HDMI
>>>>> version based on the variant's max_pixel_clock.
>>>>>
>>>>> - Provide minimal .scrambler_{enable,disable} connector callbacks that
>>>>> only toggle the VC5 HDMI_SCRAMBLER_CTL register, while delegating
>>>>> sink-side SCDC programming and periodic status monitoring to
>>>>> drm_connector_hdmi_{enable,disable}_scrambling().
>>>>>
>>>>> - Drop vc4_hdmi_reset_link() and vc4_hdmi_handle_hotplug(), switching
>>>>> the .detect_ctx() path to drm_atomic_helper_connector_hdmi_hotplug()
>>>>> which internally calls drm_connector_hdmi_sync_scdc() to trigger a
>>>>> CRTC reset on reconnection.
>>>>>
>>>>> - Drop the local scrambling_work delayed workqueue and scdc_enabled
>>>>> flag, now tracked by the common drm_connector_hdmi layer, as well as
>>>>> the now unused output_{bpc,color_format} driver data members.
>>
>> [...]
>>
>>> I'm going to test both fixes and send them out as a separate series, so we're
>>> not blocking on it.
>>
>> I submitted the fixes earlier today:
>>
>> https://lore.kernel.org/all/20261104-hdmi-scdc-scramb-fixes-v1-0-16a9bb3d64a6@xxxxxxxxxxxxx/
>>
>> I'm waiting for Lucas' scrambling patches to land in drm-misc-next so that I can
>> rebase this series and send v4.
>>
>
> I believe Lucas' patches landed today in drm-misc-next.
Indeed, they weren't there when I checked earlier today, so thanks for the quick
notice. I'll prepare the next revision.
Kind regards,
Cristian