Re: [PATCH] drm/vc4: Fix firmware reference leak in vc4_hvs_bind()

[Maíra Canal]

On Fri, 06 Nov 2026 09:20:16 +0000, Wentao Liang wrote:
> The firmware reference taken via rpi_firmware_get() is leaked when
> either of the devm_clk_get() calls for the core or display clocks
> fails, as both error paths return without releasing it.
> 
> Fix it by moving the firmware lookup below the clock lookups, so that
> the reference is taken right before the firmware property is read and
> released immediately afterwards.  The rpi_firmware_find_node() call
> moves with it: the device node reference it returns would otherwise be
> leaked by those same error paths.
> 
> [...]

Applied, thanks!

[1/1] drm/vc4: Fix firmware reference leak in vc4_hvs_bind()
      commit: af200e91c7b996177aa90981b2f0e794b085d43a

Best regards,
- Maíra