Re: [PATCH v2] ARM: dts: kirkwood: Remove duplicate DS212 compatible
From: Krzysztof Kozlowski
Date: Mon Nov 09 2026 - 07:49:19 EST
On Sat, Nov 07, 2026 at 12:05:49AM -0600, Artem Novak wrote:
> The Synology DS212 Device Tree lists "synology,ds212pv10" twice
> in its compatible property. The corresponding Kirkwood binding
> also repeats this entry.
>
> Remove the duplicate from both the Device Tree and its binding
> so that the documented compatible sequence contains only unique
> identifiers.
>
> The compatible ordering is otherwise unchanged.
>
> Signed-off-by: Artem Novak <artem122novak@xxxxxxxxx>
> ---
> .../devicetree/bindings/arm/marvell/marvell,kirkwood.yaml | 1 -
> arch/arm/boot/dts/marvell/kirkwood-ds212.dts | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
You also should have Fixes tags.
Best regards,
Krzysztof