Re: [PATCH 1/2] dt-bindings: embedded-controller: Add HP OmniBook 5 16 EC

[Krzysztof Kozlowski]

On 09/11/2026 11:49, Rahul Pon wrote:
> The HP OmniBook 5 16 (Snapdragon X2) has an embedded controller on I2C
> at address 0x76. It runs the fan and the keyboard backlight and reports
> the fan speed and its thermistor temperatures.
> 
> Signed-off-by: Rahul Pon <theflyingrahul@xxxxxxxxx>
> ---
>  .../hp,omnibook-5-16-bf1xxx-ec.yaml           | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/embedded-controller/hp,omnibook-5-16-bf1xxx-ec.yaml
> 
> diff --git a/Documentation/devicetree/bindings/embedded-controller/hp,omnibook-5-16-bf1xxx-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/hp,omnibook-5-16-bf1xxx-ec.yaml
> new file mode 100644
> index 0000000000..be4c845067
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/embedded-controller/hp,omnibook-5-16-bf1xxx-ec.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/embedded-controller/hp,omnibook-5-16-bf1xxx-ec.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: HP OmniBook 5 16 Embedded Controller
> +
> +maintainers:
> +  - Rahul Pon <theflyingrahul@xxxxxxxxx>
> +
> +description:
> +  The embedded controller of the HP OmniBook 5 16 (Snapdragon X2), on an
> +  I2C bus. It runs the fan and the keyboard backlight and reports the fan
> +  speed and its thermistor temperatures. Its four thermistors can serve
> +  as thermal sensors, indexed 0 to 3.
> +
> +properties:
> +  compatible:
> +    const: hp,omnibook-5-16-bf1xxx-ec
> +
> +  reg:
> +    const: 0x76
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  "#thermal-sensor-cells":
> +    const: 1

Looks incomplete, test your DTS. Your driver mentions interrupt.

Best regards,
Krzysztof